bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

incorrect caching messages


From: Eric Blake
Subject: incorrect caching messages
Date: Wed, 15 Nov 2006 17:02:00 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Currently, when rerunning the m4 configure script with caching enabled, this 
output is appearing:

checking for intmax_t... (cached) yes
(cached) (cached) checking whether to enable assertions... no

I tracked both of those spurious messages to this.  gl_ALLOCSA was calling 
gl_FUNC_ALLOCA rather than AC_REQUIRE'ing it, so gl_FUNC_ALLOCA got expanded 
twice in a row since the use of the allocsa module also pulls in the invocation 
of gl_FUNC_ALLOCA from the alloca-opt module.  Then gl_FUNC_ALLOCA was using a 
cache variable, but without any useful messages.

OK to install?

2006-11-15  Eric Blake  <address@hidden>

        * m4/alloca.m4 (gl_FUNC_ALLOCA): Use AC_CACHE_CHECK to avoid a
        random "(cached)" in configure output.
        * m4/allocsa.m4 (gl_ALLOCSA): Don't invoke macro already picked
        up by the module dependency.

Index: m4/alloca.m4
===================================================================
RCS file: /sources/gnulib/gnulib/m4/alloca.m4,v
retrieving revision 1.8
diff -u -b -r1.8 alloca.m4
--- m4/alloca.m4        20 Oct 2006 13:50:26 -0000      1.8
+++ m4/alloca.m4        15 Nov 2006 17:00:14 -0000
@@ -1,4 +1,4 @@
-# alloca.m4 serial 6
+# alloca.m4 serial 7
 dnl Copyright (C) 2002-2004, 2006 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -17,7 +17,7 @@
 
   # Define an additional variable used in the Makefile substitution.
   if test $ac_cv_working_alloca_h = yes; then
-    AC_CACHE_VAL([gl_cv_rpl_alloca], [
+    AC_CACHE_CHECK([whether alloca must be replaced], [gl_cv_rpl_alloca], [
       AC_EGREP_CPP([Need own alloca], [
 #if defined __GNUC__ || defined _AIX || defined _MSC_VER
           Need own alloca
Index: m4/allocsa.m4
===================================================================
RCS file: /sources/gnulib/gnulib/m4/allocsa.m4,v
retrieving revision 1.5
diff -u -b -r1.5 allocsa.m4
--- m4/allocsa.m4       20 Oct 2006 13:51:02 -0000      1.5
+++ m4/allocsa.m4       15 Nov 2006 17:00:14 -0000
@@ -1,4 +1,4 @@
-# allocsa.m4 serial 5
+# allocsa.m4 serial 6
 dnl Copyright (C) 2003-2004, 2006 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -8,7 +8,6 @@
 [
   dnl Use the autoconf tests for alloca(), but not the AC_SUBSTed variables
   dnl @ALLOCA@ and @address@hidden
-  gl_FUNC_ALLOCA
   AC_REQUIRE([gl_EEMALLOC])
   AC_REQUIRE([AC_TYPE_LONG_LONG_INT])
   AC_REQUIRE([gt_TYPE_LONGDOUBLE])






reply via email to

[Prev in Thread] Current Thread [Next in Thread]