[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Some free()s in module 'relocatable'
From: |
Sylvain Beucler |
Subject: |
Re: Some free()s in module 'relocatable' |
Date: |
Sat, 29 Dec 2007 23:13:58 +0100 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
> Sylvain Beucler <address@hidden> writes:
>
> > Attached is a small patch to fix a couple non-fred memory blocks. They
> > are not a big deal, but they do produce noise when analyzing programs
> > with memory checkers such as Valgrind.
>
> I do not see the attachment.
>
> > Another thing:, the relocatable module documentation recommends using:
> > bindtextdomain (PACKAGE, relocate (LOCALEDIR));
> > however, the result of relocate may be LOCALEDIR itself (no
> > relocation) or a newly allocated string.
> [...]
> > Maybe it would be cleaner to always return a newly allocated string?
>
> This does seem reasonable to me, but I will wait to hear Bruno's
> opinion before I do anything.
> --
> Ben Pfaff
> http://benpfaff.org
Hi,
(I'm not subscribed to the list, please keep me in Cc)
Sorry, I do attach the patch now :)
--
Sylvain
relocatable.patch
Description: Text Data