[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] vasnprintf.c: Avoid warning about unused label
From: |
Jim Meyering |
Subject: |
[PATCH] vasnprintf.c: Avoid warning about unused label |
Date: |
Tue, 29 Jan 2008 10:37:29 +0100 |
Hi Bruno,
I saw this warning:
vasnprintf.c: In function 'vasnprintf':
vasnprintf.c:4657: warning: label 'overflow' defined but not used
and propose to eliminate it like this:
vasnprintf.c: Avoid warning about unused label
* lib/vasnprintf.c (VASNPRINTF) [!USE_SNPRINTF]: Guard the
"overflow" label definition and associated code with the
same cpp condition that guards the sole use of that label.
Ok to commit?
---
diff --git a/lib/vasnprintf.c b/lib/vasnprintf.c
index 7e533be..19cc009 100644
--- a/lib/vasnprintf.c
+++ b/lib/vasnprintf.c
@@ -4327,7 +4327,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
if (prec_ourselves)
{
/* Handle the precision. */
- TCHAR_T *prec_ptr =
+ TCHAR_T *prec_ptr =
# if USE_SNPRINTF
(TCHAR_T *) (result + length);
# else
@@ -4654,6 +4654,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
not have this limitation. */
return result;
+#if USE_SNPRINTF
overflow:
if (!(result == resultbuf || result == NULL))
free (result);
@@ -4662,6 +4663,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
CLEANUP ();
errno = EOVERFLOW;
return NULL;
+#endif
out_of_memory:
if (!(result == resultbuf || result == NULL))
--
1.5.4.rc5.1.ge6bfe
- [PATCH] vasnprintf.c: Avoid warning about unused label,
Jim Meyering <=