Re: setsockopt on mingw

[Ralf Wildenhues]

Hi Simon,

* Simon Josefsson wrote on Mon, Apr 28, 2008 at 04:39:08PM CEST:
> --- a/m4/sys_socket_h.m4
> +++ b/m4/sys_socket_h.m4
> @@ -45,6 +45,7 @@ AC_DEFUN([gl_HEADER_SYS_SOCKET],
>        HAVE_WINSOCK2_H=0
>        HAVE_WS2TCPIP_H=0
>      else
> +      AC_REQUIRE([AC_C_INLINE])
>        HAVE_SYS_SOCKET_H=0
>        dnl We cannot use AC_CHECK_HEADERS_ONCE here, because that would make
>        dnl the check for those headers unconditional; yet cygwin reports

Please note that AC_REQUIRE does not operate the way this change makes
people believe.  It causes the text of AC_C_INLINE to be expanded
*before* the beginning of the expansion of gl_HEADER_SYS_SOCKET.

Even if that is clear to you now, it will confuse others reading your
code.  That confusion is lessened if you stick to listing AC_REQUIRE
stanzas at the very beginning of macro definitions, outside of any
shell conditional statements.

Cheers,
Ralf