[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fts.m4: correct the test for statfs.f_type
From: |
Bruno Haible |
Subject: |
Re: [PATCH] fts.m4: correct the test for statfs.f_type |
Date: |
Thu, 2 Oct 2008 02:51:50 +0200 |
User-agent: |
KMail/1.5.4 |
Hi Jim,
> If someone is interested enough to time things on HP-UX
> and finds that there's a file system type (probably memory backed)
> that it'd be good to exempt, then it might be worthwhile to
> pursue this.
I didn't mean to discuss for which filesystems on HP-UX which optimization
may be worthwhile. (Probably it's reasonable to treat NFS on HP-UX like
NFS on other platforms.)
Rather I meant to say that in order to get 'struct statfs' defined, a
simple "#include <sys/statfs.h>" is not enough, and this would be better:
--- m4/fts.m4.orig 2008-10-02 02:50:50.000000000 +0200
+++ m4/fts.m4 2008-10-02 02:44:07.000000000 +0200
@@ -24,8 +24,16 @@
gl_FUNC_OPENAT
AC_CHECK_FUNCS_ONCE([fstatfs])
- AC_CHECK_HEADERS_ONCE([sys/param.h sys/vfs])dnl
+ AC_CHECK_HEADERS_ONCE([sys/param.h sys/statfs.h sys/mount.h sys/vfs.h])dnl
AC_CHECK_MEMBERS([struct statfs.f_type],,,
[$ac_includes_default
- #include <sys/statfs.h>])
+ #if HAVE_SYS_STATFS_H
+ # include <sys/statfs.h>
+ #endif
+ #if HAVE_SYS_MOUNT_H
+ # include <sys/mount.h>
+ #endif
+ #if HAVE_SYS_VFS_H
+ # include <sys/vfs.h>
+ #endif])
])