[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] random_r: new module
From: |
Jim Meyering |
Subject: |
Re: [PATCH] random_r: new module |
Date: |
Fri, 24 Oct 2008 15:49:29 +0200 |
Simon Josefsson <address@hidden> wrote:
> Bruno Haible <address@hidden> writes:
>
>> If you put a #include inside an extern "C" { ... } block, like this, it
>> yields
>> a syntax error in C++ mode on some platforms. Better put the #include
>> before the extern "C" block, like this:
>
> I like the patch better. Jim?
Looks fine. You're welcome to push it.
>> 2008-10-23 Simon Josefsson <address@hidden>
>> Bruno Haible <address@hidden>
>>
>> * lib/stdlib.in.h (@GNULIB_RANDOM_R@): Include stdint.h.
>> * modules/random_r (Depends-on): Add stdint.
>>
>> *** lib/stdlib.in.h.orig 2008-10-24 02:03:38.000000000 +0200
>> --- lib/stdlib.in.h 2008-10-24 02:03:29.000000000 +0200
>> ***************
>> *** 41,46 ****
>> --- 41,50 ----
>> # include <sys/loadavg.h>
>> #endif
>>
>> + #if @GNULIB_RANDOM_R@
>> + # include <stdint.h>
>> + #endif
>> +
>> /* The definition of GL_LINK_WARNING is copied here. */
>>
>>
>> *** modules/random_r.orig 2008-10-24 02:03:38.000000000 +0200
>> --- modules/random_r 2008-10-24 02:02:04.000000000 +0200
>> ***************
>> *** 7,12 ****
>> --- 7,13 ----
>>
>> Depends-on:
>> stdlib
>> + stdint
>>
>> configure.ac:
>> gl_FUNC_RANDOM_R
- Re: [PATCH] random_r: new module, (continued)
- Re: [PATCH] random_r: new module, Simon Josefsson, 2008/10/23
- Re: [PATCH] random_r: new module, Richard W.M. Jones, 2008/10/23
- Re: [PATCH] random_r: new module, Simon Josefsson, 2008/10/23
- Re: [PATCH] random_r: new module, Simon Josefsson, 2008/10/24
- Re: [PATCH] random_r: new module,
Jim Meyering <=
- Re: [PATCH] random_r: new module, Bruno Haible, 2008/10/24