bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: parallel make and the maintainer GNUmakefile


From: Ralf Wildenhues
Subject: Re: parallel make and the maintainer GNUmakefile
Date: Sat, 14 Mar 2009 16:56:13 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

* Jim Meyering wrote on Sat, Mar 14, 2009 at 03:02:52PM CET:
> Ralf Wildenhues wrote:
> >     GNUmakefile: disable parallelism only for multiple, recursive targets
> >
> >     * top/GNUmakefile (ALL_RECURSIVE_TARGETS): New macro; allow user
> >     additions in the Makefile.
> >     (AM_RECURSIVE_TARGETS): New macro, override only if not provided
> >     by Automake.
> >     (.NOTPARALLEL): Only disable parallel builds if multiple targets
> >     are listed on the command line and at least one of them is
> >     listed in $(ALL_RECURSIVE_TARGETS).

> Thanks for dealing with that.
> It's been a thorn in my side for ages,
> though it's been off my radar until recently.
> Your second patch is fine with me.
> It makes "make syntax-check" noticeably faster, too.

Thanks.  Pushed, after updating the copyright years, and adding this
trivial patch (hope you don't mind).

Cheers,
Ralf

    * top/GNUmakefile (_have-git-version-gen): Fix typo.

diff --git a/top/GNUmakefile b/top/GNUmakefile
index 14b6fcd..33eb3aa 100644
--- a/top/GNUmakefile
+++ b/top/GNUmakefile
@@ -64,7 +64,7 @@ ifeq ($(_have-git-version-gen)0,yes$(MAKELEVEL))
                    && $(_build-aux)/git-version-gen .tarball-version)
     ifneq ($(_curr-ver),$(VERSION))
       ifeq ($(_curr-ver),UNKNOWN)
-        $(info WARNING: unable to verify if $(VERSION) is correct version)
+        $(info WARNING: unable to verify if $(VERSION) is the correct version)
       else
         ifneq (,$(_is-install-target))
           # GNU Coding Standards state that 'make install' should not cause




reply via email to

[Prev in Thread] Current Thread [Next in Thread]