Re: SIZEOF macro

[Jim Meyering]

Jim Meyering wrote:
> Eric Blake wrote:
>> According to Eric Blake on 12/24/2009 4:21 PM:
>>> According to Bruno Haible on 12/24/2009 1:08 PM:
>>>>>> Either way we create macros.h and put ASSERT there
>>>> Done this this big commit, now.
>>>
>>> Hmm.  macros.h defines SIZEOF, and test-argv-iter.c defines
>>> ARRAY_CARDINALITY, both of which are used to determine the size of an
>>> array.  I kind of prefer the name in test-argv-iter (to me, sizeof implies
>>> a size_t count of bytes, not the number of elements).  Is it okay to
>>> rename the macro in macros.h to ARRAY_CARDINALITY, adjust all callers, and
>>> to simplify test-argv-iter?
>>
>> Like this?  It's also pretty quick to go with a shorter name of CARDINALITY:
>
> Good compromise.

You've all probably noticed that ARRAY_CARDINALITY is publicized
via argmatch.h.  I wouldn't mind switching to a better macro name
if it came via its own -- or simply a better -- header file.