bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bootstrap: allow more than one submodule


From: Jim Meyering
Subject: Re: bootstrap: allow more than one submodule
Date: Wed, 17 Mar 2010 18:39:32 +0100

Bruno Haible wrote:
> As I understand it, 'bootstrap' currently updates all submodules when it
> wants to update only the gnulib submodule. What about packages that will have
> other submodules? Here is a proposed fix:
>
> 2010-03-14  Bruno Haible  <address@hidden>
>
>       * build-aux/bootstrap: Apply "git submodule" commands only to the
>       gnulib submodule.
>
> --- build-aux/bootstrap.orig  Sun Mar 14 14:10:16 2010
> +++ build-aux/bootstrap       Sun Mar 14 14:01:58 2010
> @@ -416,8 +416,8 @@
>  -)
>    if git_modules_config submodule.gnulib.url >/dev/null; then
>      echo "$0: getting gnulib files..."
> -    git submodule init || exit $?
> -    git submodule update || exit $?
> +    git submodule init "$gnulib_path" || exit $?
> +    git submodule update "$gnulib_path" || exit $?
...

Hi Bruno,

This may be solely a terminology problem.
These "git submodule update" commands serve solely to populate
the submodule clones.  They don't "update" in the sense
of transitioning to the latest SHA1 in a submodule.

As such, I think we *do* want these commands to operate
on all submodules.  Don't you?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]