[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] forkpty, openpty: split functions into new modules
From: |
Eric Blake |
Subject: |
Re: [PATCH 2/3] forkpty, openpty: split functions into new modules |
Date: |
Fri, 19 Mar 2010 09:46:05 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b1 Thunderbird/3.0.3 |
On 03/19/2010 03:07 AM, Simon Josefsson wrote:
> It may be cleanest to split the test modules too, so there is one
> test-forkpty.c and test-openpty.c.
Yeah, I did that in v2 of the patch, which means there are no
dependencies between forkpty and openpty (either one can be used/tested
in isolation).
I've incorporated Bruno's latest review, and pushed the series.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- ‘pty’ module fails on FreeBSD 7.2, Ludovic Courtès, 2010/03/16
- Re: ‘pty’ module fails on FreeBSD 7.2, Ralf Wildenhues, 2010/03/16
- Re: ‘pty’ module fails on FreeBSD 7.2, Ludovic Courtès, 2010/03/17
- Re: ‘pty’ module fails on FreeBSD 7.2, Eric Blake, 2010/03/17
- [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Simon Josefsson, 2010/03/19
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules,
Eric Blake <=
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/19
- [PATCH 1/3] pty: improve replacement header, Eric Blake, 2010/03/18
- Re: [PATCH 1/3] pty: improve replacement header, Bruno Haible, 2010/03/18
- Re: [PATCH 1/3] pty: improve replacement header, Bruno Haible, 2010/03/19
- [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Eric Blake, 2010/03/18
- Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Bruno Haible, 2010/03/18
- Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Eric Blake, 2010/03/18
- [PATCHv2 1/3] pty: improve replacement header, Eric Blake, 2010/03/18
- [PATCHv2 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCHv2 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/21