[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] describe --local-dir option in documentation
From: |
Bruno Haible |
Subject: |
Re: [PATCH] describe --local-dir option in documentation |
Date: |
Wed, 9 Jun 2010 12:32:03 +0200 |
User-agent: |
KMail/1.9.9 |
Hi Ben,
Thanks for the work on this. Looks quite good, nearly ready to commit.
Just three small remarks:
> +``foobar'' needs a modified version of, say, @file{stdint_.h}, it
Nowadays this file is called @file{stdint.in.h}.
> ... or it has to use the
> address@hidden option and provide the modified @code{stdint}
> +module in a different directory and use libtool convenience libraries.
I don't understand the part "and use libtool convenience libraries". The
user can provide a modified module, and gnulib-tool will use the
modified module just like it would use the original gnulib module. There
is no need to create a .a library that includes another .a library.
Additionally, the 'stdint' module does not provide a .o file, making
this sentence even more confusing. [Yes I know it was me who wrote this
sentence 4 years ago ;-)]
> address@hidden
> +You can also add unstructured amounts of code to the library, by grouping
> +the non-Gnulib files of the library in a single kitchen-sink ``module.''
Here one could add a remark that this kind of kitchen-sink module is not
needed when you use the gnulib-tool option @samp{--makefile-name}.
You are then welcome to commit and push this. Many thanks!
Bruno