[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix buglet in code searching for a good shell (tests/init.sh
From: |
Jim Meyering |
Subject: |
Re: [PATCH] Fix buglet in code searching for a good shell (tests/init.sh). |
Date: |
Fri, 11 Jun 2010 19:04:29 +0200 |
Ralf Wildenhues wrote:
> Hi Jim,
>
> * Jim Meyering wrote on Fri, Jun 11, 2010 at 01:49:35PM CEST:
>> +warn_() { echo "$@" 1>&$stderr_fileno_; }
>> +fail_() { warn_ "$ME_: failed test: $@"; Exit 1; }
>> +skip_() { warn_ "$ME_: skipped test: $@"; Exit 77; }
>> +framework_failure_() { warn_ "$ME_: set-up failure: $@"; Exit 1; }
>
> You may want to Exit 99 for a framework failure. The Automake
> parallel-tests interprets that as an unexpected failure even if
> the test is listed in XFAIL_TESTS. (The old test driver didn't
> and doesn't do that.)
Thanks, Ralf.
Your words, so...
>From e69a17d02ee0bc09acf4498515fd6934160c9923 Mon Sep 17 00:00:00 2001
From: Ralf Wildenhues <address@hidden>
Date: Fri, 11 Jun 2010 19:03:33 +0200
Subject: [PATCH] init.sh: change framework_failure_ to fail with status 99, not
1
* tests/init.sh (framework_failure_): Exit 99, not 1. This informs
automake's parallel-tests rule that this is an unexpected failure,
even if the test is listed in XFAIL_TESTS.
---
ChangeLog | 7 +++++++
tests/init.sh | 2 +-
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 6a366ed..84f2eff 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-06-11 Ralf Wildenhues <address@hidden>
+
+ init.sh: change framework_failure_ to fail with status 99, not 1
+ * tests/init.sh (framework_failure_): Exit 99, not 1. This informs
+ automake's parallel-tests rule that this is an unexpected failure,
+ even if the test is listed in XFAIL_TESTS.
+
2010-06-11 Jim Meyering <address@hidden>
test-inttostr: avoid warnings about 4-6KB literal strings
diff --git a/tests/init.sh b/tests/init.sh
index 286bbf1..7943526 100644
--- a/tests/init.sh
+++ b/tests/init.sh
@@ -77,7 +77,7 @@ Exit () { set +e; (exit $1); exit $1; }
warn_() { echo "$@" 1>&$stderr_fileno_; }
fail_() { warn_ "$ME_: failed test: $@"; Exit 1; }
skip_() { warn_ "$ME_: skipped test: $@"; Exit 77; }
-framework_failure_() { warn_ "$ME_: set-up failure: $@"; Exit 1; }
+framework_failure_() { warn_ "$ME_: set-up failure: $@"; Exit 99; }
# We require $(...) support unconditionally.
# We require a few additional shell features only when $EXEEXT is nonempty,
--
1.7.1.501.g23b46