|
From: | Paolo Bonzini |
Subject: | Re: [PATCH v2 0/5] Speed up uNN_chr and uNN_strchr with Boyer-Moore algorithm |
Date: | Tue, 27 Jul 2010 20:14:41 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5 |
On 07/27/2010 06:06 PM, Pádraig Brady wrote:
On 23/07/10 13:03, Paolo Bonzini wrote:On 07/23/2010 09:21 AM, Bruno Haible wrote:Otherwise fine, please commit. I can add comments that prove the validity of the code later, after you committed it.v2 already had large comments that detail the algorithm used and do include all the info in the comments you suggested. Feel free to add more to it. I pushed it now, thanks for the review!I would suggest a new function due to the way I see this function called most often. I.E. repeatedly with the same character.
Is this really a bottleneck? i.e., what does u8_uctomb_aux look like in the profile when do a million u8_strchr calls on an empty string?
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |