bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv2 4/9] save-cwd: reduce dependency


From: Bruno Haible
Subject: Re: [PATCHv2 4/9] save-cwd: reduce dependency
Date: Wed, 27 Apr 2011 03:03:16 +0200
User-agent: KMail/1.9.9

Eric Blake wrote:
> diff --git a/modules/save-cwd b/modules/save-cwd
> index 02a0723..974b596 100644
> --- a/modules/save-cwd
> +++ b/modules/save-cwd
> @@ -9,7 +9,7 @@ m4/save-cwd.m4
>  Depends-on:
>  chdir-long
>  cloexec
> -getcwd
> +getcwd-lgpl
>  fchdir
>  stdbool
>  unistd-safer

Here it would be useful to add a comment to lib/save-cwd.c that explains:
This code can be use with either the module 'getcwd' or 'getcwd-lgpl'. Using
module 'getcwd' makes it less likely that save_cwd fails, so it is preferred.

Bruno
-- 
In memoriam Heinrich Conradi <http://de.wikipedia.org/wiki/Heinrich_Conradi>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]