Re: [PATCH]: pselect: new module

[Bruno Haible]

Hi Paul,

More comments:

> +++ b/m4/pselect.m4
> @@ -0,0 +1,31 @@
> +# pselect.m4

No serial number here?

> +  if test $ac_cv_func_pselect = no || test $gl_cv_sig_pselect = no; then
> +    REPLACE_PSELECT=1
> +  fi

> +#undef pselect
> +

> +int
> +rpl_pselect (int nfds, fd_set *restrict rfds,

These are not the usual idioms, and will define a symbol 'rpl_pselect' when
'pselect' would be more appropriate (which is disturbing when debugging).

To follow the usual idioms:
  - set HAVE_PSELECT = 0, not REPLACE_PSELECT = 1, if the function doesn't 
exist,
  - define the function pselect, not rpl_pselect,
  - don't #undef pselect, since you aren't going to call it in this file.

Bruno
-- 
In memoriam Yuri Shchekochikhin 
<http://en.wikipedia.org/wiki/Yuri_Shchekochikhin>