Re: [PATCH 05/10] * lib/pselect.c (pselect): Use plain name, without "rpl_".

[Stefano Lattarini]

Hello Paul, and sorry if I chime in only to criticize...

On Wednesday 06 July 2011, Paul Eggert wrote:
> Don't #undef,  since we don't need any underlying pselect.
> * modules/pselect (Depends-on): Use our pselect.o if !HAVE_PSELECT.
> Both changes suggested by Bruno Haible.
>
This commit message seems wrong; for what I can see below, you've
modified the 'configure.ac' section of modules/pselect, not the
'Depens-on' section.

Moreover, the commit message lacks a proper "short description" line,
which means that it will appear messed up when it gets displayed by
"git log" (or by useful GUIs like qgit).

> ---
>  ChangeLog       |    5 +++++
>  lib/pselect.c   |   10 ++++------
>  modules/pselect |    2 +-
>  3 files changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index 35b2fa8..e815b29 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,10 @@
>  2011-07-05  Paul Eggert  <address@hidden>
>  
> +     * lib/pselect.c (pselect): Use plain name, without "rpl_".
> +     Don't #undef,  since we don't need any underlying pselect.
> +     * modules/pselect (Depends-on): Use our pselect.o if !HAVE_PSELECT.
> +     Both changes suggested by Bruno Haible.
> +
>       pselect: document better
>       * MODULES.html.sh (Support for systems lacking POSIX:2008): Add it.
>       * doc/posix-functions/pselect.texi (pselect): Document new module.
> diff --git a/lib/pselect.c b/lib/pselect.c
> index 7eec89c..6b9ba22 100644
> --- a/lib/pselect.c
> +++ b/lib/pselect.c
> @@ -27,8 +27,6 @@
>  #include <errno.h>
>  #include <signal.h>
>  
> -#undef pselect
> -
>  /* Examine the size-NFDS file descriptor sets in RFDS, WFDS, and XFDS
>     to see whether some of their descriptors are ready for reading,
>     ready for writing, or have exceptions pending.  Wait for at most
> @@ -37,10 +35,10 @@
>     or an unaffected signal mask.  */
>  
>  int
> -rpl_pselect (int nfds, fd_set *restrict rfds,
> -             fd_set *restrict wfds, fd_set *restrict xfds,
> -             struct timespec const *restrict timeout,
> -             sigset_t const *restrict sigmask)
> +pselect (int nfds, fd_set *restrict rfds,
> +         fd_set *restrict wfds, fd_set *restrict xfds,
> +         struct timespec const *restrict timeout,
> +         sigset_t const *restrict sigmask)
>  {
>    int select_result;
>    sigset_t origmask;
> diff --git a/modules/pselect b/modules/pselect
> index b899198..5f6291b 100644
> --- a/modules/pselect
> +++ b/modules/pselect
> @@ -10,7 +10,7 @@ sys_select
>  
>  configure.ac:
>  gl_FUNC_PSELECT
> -if test $REPLACE_PSELECT = 1; then
> +if test $HAVE_PSELECT = 0 || test $REPLACE_PSELECT = 1; then
>    AC_LIBOBJ([pselect])
>  fi
>  gl_SYS_SELECT_MODULE_INDICATOR([pselect])
> 

Regards,
  Stefano