[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] fix not a string literal warning in test_xasprintf
From: |
g . esp |
Subject: |
Re: [PATCH v2] fix not a string literal warning in test_xasprintf |
Date: |
Sun, 22 Apr 2012 20:09:12 +0200 (CEST) |
----- Mail original -----
> De: "Bruno Haible" <address@hidden>
> À: address@hidden
> Cc: "Gilles Espinasse" <address@hidden>
> Envoyé: Jeudi 5 Avril 2012 12:32:56
> Objet: Re: [PATCH v2] fix not a string literal warning in test_xasprintf
>
> Gilles Espinasse wrote:
> > Remove the code hack preventing format-zero-length warning and
> > replace by a
> > pragma GCC diagnostic ignored in top of code.
>
> This patch is not good, because the warning "zero-length format string"
> exists at least since GCC 3.1, however
> '#pragma GCC diagnostic ignored "-Wformat-zero-length"' works only in GCC >=
> 4.2.
>
Thank for the feedback.
So I don't think that worth the effort to try fixing that warning that is in a
test and appear only with my patched gcc.
Gilles