Re: [PATCH] directory separator

[John Darrington]

On Wed, Jun 06, 2012 at 01:10:09PM -0600, Eric Blake wrote:
     On 06/06/2012 12:54 PM, John Darrington wrote:
     > I'm offering this patch which ensures that the paths of tempfiles are 
     > created with the appropriate separator for the machine.
     
     What platform did you need it on?  Windows understands paths with /,
     even if it prefers \ as the canonical separator, and no one has
     complained about mingw compilations being unable to create temp files.
     We need a bit more background why this patch would matter before it can
     be applied.
     

True.  It can create temp files with a / in the path.  But it confuses 
windows users who are used to \ especially  when the path has been 
constructed from another path with \  They see strings like:

 TEMPDIR is C:\Users\User\AppData\Local\Temp/psppJnmXOk.


Also, we've been getting bug reports from windows users which suggest 
that tempfiles are mysteriously disappearing.  I have a hypotheis 
that the use of / in the path, is interacting badly with _O_TEMPORARY flag
and causing the file to be prematurely deleted.  I don't have any fast
evidence that this is the case, but it is an inconsistency which seems
suspicious.

If as you say, windows prefers \  is there a good reason NOT to use it?

J'



-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature