[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add hash_pjw_s(), 3rd attempt
From: |
Jim Meyering |
Subject: |
Re: Add hash_pjw_s(), 3rd attempt |
Date: |
Mon, 01 Oct 2012 20:46:20 +0200 |
Nikos Mavrogiannopoulos wrote:
> On 09/27/2012 10:19 PM, Nikos Mavrogiannopoulos wrote:
>> Updated.
>
> Hello,
> Any update on that? Do you plan to include it?
Hi Nikos,
I went to deal with the mechanics of adding it and noticed a few details.
What do you think about hash_pjw_no_mod or hash_pjw_bare
as the function name? They convey more meaning than the "_s" suffix.
Also, please make it look like other new-module commits.
I.e.,
- list the module name in MODULES.html.sh
- make the first line of the commit log be "new-module-name: new module"
- add a ChangeLog entry
extra credit:
- add a test module, even though there isn't one for hash-pjw