[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: glob.c warnings
From: |
Eric Blake |
Subject: |
Re: glob.c warnings |
Date: |
Sat, 07 Sep 2013 07:04:13 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/07/2013 05:32 AM, Tom G. Christensen wrote:
>>
>> * posix/glob.c (next_brace_sub, prefix_array, collated_compare):
>> Use __THROWNL rather than __THROW on static functions.
>>
>
> This broke the build for atleast Solaris and FreeBSD.
>
> Here's an excerpt from a test build on FreeBSD 9.1:
>
> depbase=`echo glob.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; gcc
> -DHAVE_CONFIG_H -I. -I.. -DGNULIB_STRICT_CHECKING=1 -D_THREAD_SAFE -g
> -O2
> -MT glob.o -MD -MP -MF $depbase.Tpo -c -o glob.o glob.c && mv -f
> $depbase.Tpo $depbase.Po
> In file included from ./glob.h:380,
> from glob.c:24:
> ./glob-libc.h: In function 'rpl_glob':
> ./glob-libc.h:177: error: expected declaration specifiers before '__THROW'
Ah, we need _both_ spellings, as we do have other uses of __THROW. I'll
check in the obvious fix shortly.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature