[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
FTBFS c-stack under gcc 4.8 with --enable-gcc-warnings
From: |
Eric Blake |
Subject: |
FTBFS c-stack under gcc 4.8 with --enable-gcc-warnings |
Date: |
Wed, 25 Sep 2013 12:01:01 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
I tried to build diffutils from git on my Fedora 19 machine:
$ gcc --version |head -n1
gcc (GCC) 4.8.1 20130603 (Red Hat 4.8.1-1)
It's dying inside of gnulib's c-stack:
CC c-stack.o
c-stack.c: In function 'segv_handler':
c-stack.c:163:12: error: function might be candidate for attribute
'pure' if it is known to return normally [-Werror=suggest-attribute=pure]
static int segv_handler (void *address __attribute__ ((unused)),
^
cc1: all warnings being treated as errors
I don't know if this is a case of diffutils being too aggressive about
the warnings it uses on gnulib files (after all, at least coreutils
explicitly uses fewer warnings for gnulib files than for its own), or if
it is something we should be fixing in gnulib.
More interesting, the function is only pure if DEBUG was not enabled
during compilation, so if we do decide to fix it in gnulib, the fix has
to use the same condition on whether to apply the attribute.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- FTBFS c-stack under gcc 4.8 with --enable-gcc-warnings,
Eric Blake <=