[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: stdioext OpenVMS patch.
From: |
Bruno Haible |
Subject: |
Re: stdioext OpenVMS patch. |
Date: |
Sun, 02 Jul 2017 02:47:20 +0200 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-81-generic; KDE/5.18.0; x86_64; ; ) |
Hi John,
> On OpenVMS, the struct _iobuf is needed to access members of the struct
> FILE.
>
> This is a patch for the affected stdioext modules to compile on OpenVMS.
The approach looks generally right, but I'd request a couple of changes
before this can go in:
* Is _IOERR defined on OpenVMS? In some files, you treat OpenVMS
as part of the _IOERR case, in others you do it before _IOERR. Which
is not consistent.
If _IOERR is defined on OpenVMS, please update all
#elif defined _IOERR /* AIX, HP-UX, IRIX, OSF/1, Solaris,
OpenServer, mingw, MSVC, NonStop Kernel */
lines to include OpenVMS at the end of the comment.
* Instead of defining a variable 'stream', please using the same coding
style as for the other platforms: use macro fp_ which is defined to
a cast expression through lib/stdio-impl.h.
* The fbufmode.c change has a regression for all non-Windows, non-OpenVMS
platforms.
* The freading.c change is misindented.
Bruno