[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Don’t use AC_EGREP_CPP if affected by CFLAGS
From: |
Bruno Haible |
Subject: |
Re: [PATCH] Don’t use AC_EGREP_CPP if affected by CFLAGS |
Date: |
Mon, 06 Nov 2017 11:08:07 +0100 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-97-generic; KDE/5.18.0; x86_64; ; ) |
Hi Paul,
This patch is not good, IMO.
> Without this patch, ‘./configure CFLAGS="-m32"’ fails on gzip with GNU/Linux
> x86-64.
We have documented in
https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Preset-Output-Variables.html
that this is the wrong way to do a 32-bit build on 64-bit platforms. There are
two ways that work:
1) ./configure CC="gcc -m32"
2) ./configure CPPFLAGS="-m32" LDFLAGS="-m32"
This configuration issue comes up occasionally, therefore it is a documentation
problem that we should probably fix in the INSTALL file.
I'd would be in favour of reverting this change because
1) AC_COMPILE_IFELSE is slower than AC_EGREP_CPP, and there is common
consensus (discussion on gnu-prog-discuss in October 2016) that configure
scripts are already slower than it should be.
2) There are many more uses of AC_EGREP_CPP outside of gnulib.
Bruno
- [PATCH] Don’t use AC_EGREP_CPP if affected by CFLAGS, Paul Eggert, 2017/11/05
- Re: [PATCH] Don’t use AC_EGREP_CPP if affected by CFLAGS,
Bruno Haible <=
- Re: [PATCH] Don’t use AC_EGREP_CPP if affected by CFLAGS, Paul Eggert, 2017/11/06
- Re: [PATCH] Don’t use AC_EGREP_CPP if affected by CFLAGS, Bruno Haible, 2017/11/06
- Re: [PATCH] Don’t use AC_EGREP_CPP if affected by CFLAGS, Paul Eggert, 2017/11/06
- Re: [PATCH] Don’t use AC_EGREP_CPP if affected by CFLAGS, Bruno Haible, 2017/11/06
- Re: [PATCH] Don’t use AC_EGREP_CPP if affected by CFLAGS, Bruno Haible, 2017/11/06
- Re: [PATCH] Don’t use AC_EGREP_CPP if affected by CFLAGS, Paul Eggert, 2017/11/06