[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore fi
From: |
Darshit Shah |
Subject: |
Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files |
Date: |
Mon, 20 Nov 2017 13:39:14 +0100 |
User-agent: |
NeoMutt/20171027-93-b1df63 |
Hi Dmitry,
That's perfectly fine. Long as I know that it is being looked into, it's okay.
There's always so many things that are going on and other items often take
priority. No issues.
* Dmitry Selyutin <address@hidden> [171120 06:40]:
> Hi Darshit,
>
> the reason is actually very simple: I just had no time to apply it due to
> activities on a regular work. Hopefully I'll continue developing
> gnulib-tool in the end of this week. The patch seems to be OK though; I'll
> try to push it this evening. Thank you again and sorry for the delay.
>
> 20 нояб. 2017 г. 2:53 ДП пользователь "Darshit Shah" <address@hidden>
> написал:
>
> It's been a while. Atleast some response on why it isn't being accepted
> would
> be appreciated
>
> * Darshit Shah <address@hidden> [171113 09:07]:
> > Hi,
> >
> > Is there something blocking this patch? It doesn't seem like it has been
> merged
> > yet.
> >
> > * Darshit Shah <address@hidden> [170913 00:19]:
> > > * Dmitry Selyutin <address@hidden> [170911 21:32]:
> > > > Hi all,
> > > >
> > > > > As explained above, this patch helps converge gnulib-tool.py and
> > > > > gnulib-tool. There is a behavioural difference which I also
> consider to
> > > > > be a regression, and hence a string need to fix it.
> > > > Thanks for the patch! Looks perfectly fine from my side. Could you
> push it
> > > > into the repository, please?
> > > >
> > > > > But we are not there yet. Maybe in one or two weeks, but not now.
> > > > I think it is a way too optimistic forecast. Anyway, I do my best,
> though my
> > > > Python skills are a little bit rusty. :-)
> > > >
> > > > > Dmitry's work with the Python script has been great
> > > > Well, I wouldn't say after looking into the code, but at least it is
> working
> > > > somehow and can be a basic for a much better API. Remember that we're
> staying
> > > > on giants' shoulders, I've just rewritten what was created before in
> another
> > > > language. :-) Anyway, thank you for your kind words!
> > > >
> > > >
> > > > --
> > > > With best regards,
> > > > Dmitry Selyutin
> > >
> > > Bruno,
> > >
> > > Could you please push this patch to master?
> > >
> > >
> > > --
> > > Thanking You,
> > > Darshit Shah
> > > PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6
> >
> >
> >
> > --
> > Thanking You,
> > Darshit Shah
> > PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6
>
>
>
> --
> Thanking You,
> Darshit Shah
> PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6
--
Thanking You,
Darshit Shah
PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6
signature.asc
Description: PGP signature