[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnupload: fix Shellcheck warnings
|
From: |
Bruno Haible |
|
Subject: |
Re: gnupload: fix Shellcheck warnings |
|
Date: |
Wed, 28 Nov 2018 17:00:57 +0100 |
|
User-agent: |
KMail/5.1.3 (Linux/4.4.0-138-generic; KDE/5.18.0; x86_64; ; ) |
Hi Ben,
> This patch silences some warnings from Shellcheck, mostly about using
> POSIX $(..) command substitutions instead of old backtick
> substitutions.
The script starts with '#!/bin/sh'. /bin/sh on IRIX does not support
$(...). But I think no GNU maintainer is using IRIX on their development
machine. Therefore it's fine with me.
> - conf=`sed 's/#.*$//;/^$/d' "$conffile" | tr "\015$nl" ' '`
> + conf=$(sed 's/#.*$//;/^$/d' "$conffile" | tr "\\015$nl" ' ')
Is the interpretation of backslashes inside $(...) different than
inside `...`? Or is this an independent fix?
Bruno