bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bitset: properly use false/true instead of 0/1 for Booleans


From: Akim Demaille
Subject: bitset: properly use false/true instead of 0/1 for Booleans
Date: Wed, 28 Nov 2018 22:09:23 +0100

Ok to install?

commit 6d20ab4850e6bf15013e5e5a83bca5c2f31d77f9
Author: Akim Demaille <address@hidden>
Date:   Wed Nov 28 21:55:00 2018 +0100

    bitset: properly use false/true instead of 0/1 for Booleans
    
    * lib/bitset/expandable.c, lib/bitset/vector.c: Use false/true, not
    0/1, as Booleans.

diff --git a/ChangeLog b/ChangeLog
index 67b3605d7..c1a132956 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2018-11-28  Akim Demaille  <address@hidden>
+
+       bitset: properly use false/true instead of 0/1 for Booleans
+       * lib/bitset/expandable.c, lib/bitset/vector.c: Use false/true, not
+       0/1, as Booleans.
+
 2018-11-28  Akim Demaille  <address@hidden>
 
        bitset: rename BITSET_VARRAY as BITSET_VECTOR
diff --git a/lib/bitset/expandable.c b/lib/bitset/expandable.c
index e831fdc21..439112aa9 100644
--- a/lib/bitset/expandable.c
+++ b/lib/bitset/expandable.c
@@ -811,7 +811,7 @@ static bool
 ebitset_empty_p (bitset dst)
 {
   if (EBITSET_ZERO_P (dst))
-    return 1;
+    return true;
 
   ebitset_elts *elts = EBITSET_ELTS (dst);
   for (bitset_windex j = 0; j < EBITSET_SIZE (dst); j++)
@@ -821,7 +821,7 @@ ebitset_empty_p (bitset dst)
       if (elt)
         {
           if (!ebitset_elt_zero_p (elt))
-            return 0;
+            return false;
           /* Do some weeding as we go.  */
           ebitset_elt_remove (dst, j);
         }
@@ -830,7 +830,7 @@ ebitset_empty_p (bitset dst)
   /* All the bits are zero.  We could shrink the elts.
      For now just mark DST as known to be zero.  */
   EBITSET_ZERO_SET (dst);
-  return 1;
+  return true;
 }
 
 
diff --git a/lib/bitset/vector.c b/lib/bitset/vector.c
index df54ee085..387552255 100644
--- a/lib/bitset/vector.c
+++ b/lib/bitset/vector.c
@@ -419,14 +419,12 @@ vbitset_subset_p (bitset dst, bitset src)
   unsigned i;
   for (i = 0; i < min (ssize, dsize); i++, dstp++, srcp++)
     if (*dstp != (*srcp | *dstp))
-      return 0;
+      return false;
 
   if (ssize > dsize)
-    {
-      for (; i < ssize; i++)
-        if (*srcp++)
-          return false;
-    }
+    for (; i < ssize; i++)
+      if (*srcp++)
+        return false;
 
   return true;
 }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]