bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: array-list: Pacify warnings about unused arguments (-Wunused-paramet


From: Eric Blake
Subject: Re: array-list: Pacify warnings about unused arguments (-Wunused-parameter)
Date: Wed, 23 Jan 2019 16:24:34 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/23/19 3:37 PM, Akim Demaille wrote:
> In Bison.
> 
> commit decda5a491a8e8900bea0f4346d8dfca191d4b90
> Author: Akim Demaille <address@hidden>
> Date:   Wed Jan 23 22:36:54 2019 +0100
> 
>     array-list: Pacify warnings about unused arguments (-Wunused-parameter)
>     
>     * lib/gl_array_list.c (gl_array_iterator_free): "Use" the argument.

> +++ b/lib/gl_array_list.c
> @@ -514,6 +514,7 @@ gl_array_iterator_next (gl_list_iterator_t *iterator,
>  static void
>  gl_array_iterator_free (gl_list_iterator_t *iterator)
>  {
> +  (void) iterator;

Why not this:

-gl_array_iterator_free (gl_list_iterator_t *iterator)
+gl_array_iterator_free (gl_list_iterator_t *iterator _GL_UNUSED)

like we do elsewhere?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]