[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: undefined behaviour findings in bitset
From: |
Akim Demaille |
Subject: |
Re: undefined behaviour findings in bitset |
Date: |
Sun, 17 Mar 2019 08:39:29 +0100 |
> Le 16 mars 2019 à 20:53, Bruno Haible <address@hidden> a écrit :
>
> Hi Akim,
>
> In the first patch:
>> + for (bitset_windex windex = bitno / BITSET_WORD_BITS;
>> + (windex - woffset) < EBITSET_ELT_WORDS; windex++)
>
> This is C99 syntax. If you don't add 'c99' as a dependency of your
> module, the module will not compile with GCC versions < 5.1.0 with
> their default settings.
hi Bruno,
bitset is already implemented in C99, it's not a new requirement.
I was unaware of the c99 module. I installed the following commit
in addition to the ones I submitted.
Cheers!
commit 4d9813bf6bbf6489c1de4ad9d48943b961976bce
Author: Akim Demaille <address@hidden>
Date: Sun Mar 17 08:34:22 2019 +0100
bitset, timevar: Depend on c99
Reported by Bruno Haible.
* modules/bitset, modules/timevar (Depends-on): Add c99.
diff --git a/ChangeLog b/ChangeLog
index 97b20b909..9ce4bf24c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2019-03-17 Akim Demaille <address@hidden>
+
+ bitset, timevar: Depend on c99.
+ Reported by Bruno Haible.
+ * modules/bitset, modules/timevar (Depends-on): Add c99.
+
2019-03-16 Akim Demaille <address@hidden>
bitset: a bit (...) more tests
diff --git a/modules/bitset b/modules/bitset
index 76d1a2cac..81b71c0c7 100644
--- a/modules/bitset
+++ b/modules/bitset
@@ -17,6 +17,7 @@ lib/bitset/vector.c
lib/bitset/vector.h
Depends-on:
+c99
gettext-h
obstack
xalloc
diff --git a/modules/timevar b/modules/timevar
index 3e1eb48f7..ef86fedb2 100644
--- a/modules/timevar
+++ b/modules/timevar
@@ -6,6 +6,7 @@ lib/timevar.h
lib/timevar.c
Depends-on:
+c99
gethrxtime
getrusage
gettext-h
- undefined behaviour findings, Bruno Haible, 2019/03/09
- Re: undefined behaviour findings in bitset, Bruno Haible, 2019/03/09
- Re: undefined behaviour findings in bitset, Akim Demaille, 2019/03/16
- Re: undefined behaviour findings in bitset, Akim Demaille, 2019/03/16
- Re: undefined behaviour findings in bitset, Bruno Haible, 2019/03/16
- Re: undefined behaviour findings in bitset,
Akim Demaille <=
- Re: undefined behaviour findings in bitset, Akim Demaille, 2019/03/17
- Re: undefined behaviour findings in bitset, Paul Eggert, 2019/03/17
- Re: undefined behaviour findings in bitset, Bruno Haible, 2019/03/17
- Re: undefined behaviour findings in bitset, Akim Demaille, 2019/03/18
- Re: undefined behaviour findings in bitset, Bruno Haible, 2019/03/18
- Re: undefined behaviour findings in bitset, Akim Demaille, 2019/03/19
- Re: undefined behaviour findings in bitset, Akim Demaille, 2019/03/22
- Re: undefined behaviour findings in bitset, Bruno Haible, 2019/03/23
- Re: undefined behaviour findings in bitset, Bruno Haible, 2019/03/19
- Re: undefined behaviour findings in bitset, Akim Demaille, 2019/03/20