Re: lib/fbufmode.c

[Tim Rice]

Never mind, I can't read today.

On Thu, 24 Sep 2020, Tim Rice wrote:

> 
> This does not look right.
> -------
> 57    #elif defined _IOERR                /* AIX, HP-UX, IRIX, OSF/1, 
> Solaris, OpenServer, mingw, MSVC, NonStop Kernel, OpenVMS */
> 58    # if defined WINDOWS_OPAQUE_FILE
> 59      if (fp_->_flag & 0x100)
> 60        return _IOFBF; /* Impossible to distinguish _IOFBF and _IOLBF.  */
> 61      else
> 62        return _IONBF;
> 63    # else
> 64    #  if HAVE___FLBF                   /* Solaris >= 7, UnixWare 7.1.4 >= 
> MP4 */
> 65      if (__flbf (fp))
> 66        return _IOLBF;
> 67    #  else
> 68      if (fp_->_flag & _IOLBF)
> 69        return _IOLBF;
> 70    #  endif
> 71      if (fp_->_flag & _IONBF)
> 72        return _IONBF;
> 73      return _IOFBF;
> 74    # endif
> 75    #elif defined __UCLIBC__            /* uClibc */
> -------
> 
> Lines 71 and 72 look like they should not be there since if
> there is no __flbf, lines 68 and 69 cover that.
> 
> 

-- 
Tim Rice                                Multitalents    (707) 456-1146
tim@multitalents.net