bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Avoid DoS vulnerability through unsafe default assignment


From: Bruno Haible
Subject: Re: Avoid DoS vulnerability through unsafe default assignment
Date: Sun, 31 Jul 2022 07:19:36 +0200

> 2022-07-23  Bruno Haible  <bruno@clisp.org>
> 
>       Avoid DoS vulnerability through unsafe default assignment.
>       See https://www.shellcheck.net/wiki/SC2223 .

This change caused an error in gendocs.sh:

  Generating monolithic html... (env LANG= LC_MESSAGES= LC_ALL= LANGUAGE= 
makeinfo --no-split --html -o gnulib.html   -I '../build-aux'  
--css-ref=https://www.gnu.org/software/gnulib/manual.css -c 
TOP_NODE_UP_URL=/manual "/GNULIB/gnulib/doc/gnulib.texi")
  ../build-aux/gendocs.sh: 249: 'perl': not found

This patch fixes it.


2022-07-31  Bruno Haible  <bruno@clisp.org>

        gendocs.sh: Fix error when invoking 'perl' (regression 2022-07-23).
        * build-aux/gendocs.sh (PERL): Use double-quotes, not single-quotes.

diff --git a/build-aux/gendocs.sh b/build-aux/gendocs.sh
index 2411a850ca..f6811eea46 100755
--- a/build-aux/gendocs.sh
+++ b/build-aux/gendocs.sh
@@ -47,7 +47,7 @@ 
templateurl="https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/gendocs_temp
 : "${DOCBOOK2PDF="docbook2pdf"}"
 : "${DOCBOOK2TXT="docbook2txt"}"
 : "${GENDOCS_TEMPLATE_DIR="."}"
-: "${PERL='perl'}"
+: "${PERL="perl"}"
 : "${TEXI2HTML="texi2html"}"
 unset CDPATH
 unset use_texi2html






reply via email to

[Prev in Thread] Current Thread [Next in Thread]