bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

uses of xinmalloc and xpmalloc triggered make syntax-check failure


From: Jim Meyering
Subject: uses of xinmalloc and xpmalloc triggered make syntax-check failure
Date: Tue, 06 Jun 2023 21:34:53 -0700

I noticed some syntax-check failures in diffutils.
Its uses of relatively new xinmalloc and xpmalloc functions triggered a
"make syntax-check" failure claiming that xalloc.h need not be included,
because none of its (old list) functions was used. This updates the regex
to match the current list of functions.

I expect to regenerate other syntax-checked header regexps
and may find time to automate the update process.

>From 1496e1fbe5bd7a9302d9168e9dc1864f1e435547 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@meta.com>
Date: Tue, 6 Jun 2023 20:49:22 -0700
Subject: [PATCH] maint.mk: regenerate regex to reflect new functions in
 xalloc.h

* top/maint.mk (sc_prohibit_xalloc_without_use) [_xa1]:
Regenerate using the command listed in the comment.
---
 ChangeLog    | 6 ++++++
 top/maint.mk | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 57780d3fec..4bbdb9ccf3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2023-06-06  Jim Meyering  <meyering@meta.com>
+
+       maint.mk: regenerate regex to reflect new functions in xalloc.h
+       * top/maint.mk (sc_prohibit_xalloc_without_use) [_xa1]:
+       Regenerate using the command listed in the comment.
+
 2023-06-06  Paul Eggert  <eggert@cs.ucla.edu>

        propername: pacify po_check
diff --git a/top/maint.mk b/top/maint.mk
index 4f5729fac1..12004f9be1 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -614,7 +614,7 @@ sc_prohibit_error_without_use:
 # 2) notice that "c(har)?|[mz]" is equivalent to the shorter and more readable
 # "char|[cmz]"
 # x(((2n?)?re|char|n(re|m)|[cmz])alloc|alloc_(oversized|die)|(mem|str)dup)
-_xa1 = x(((2n?)?re|char|n(re|m)|[cmz])alloc|alloc_(oversized|die)|(mem|str)dup)
+_xa1 = 
x(i(m(emdup0?|alloc)|realloc(array)?|([cz]|nm)alloc)|([pz]|c(har)?|2n?re|nm)alloc|realloc(array)?|m(alloc|emdup)|strdup)
 _xa2 = X([CZ]|N?M)ALLOC
 sc_prohibit_xalloc_without_use:
        @h='xalloc.h' \
-- 
2.41.0


reply via email to

[Prev in Thread] Current Thread [Next in Thread]