bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Spelling fixes for gnulib


From: Bruno Haible
Subject: Re: Spelling fixes for gnulib
Date: Fri, 09 Jun 2023 11:11:17 +0200

Hi Paul,

Thanks for going through the list.

But I believe that this one is wrong:

> diff --git a/lib/argp.h b/lib/argp.h
> index 7de939a2a1..404a631ca7 100644
> --- a/lib/argp.h
> +++ b/lib/argp.h
> @@ -407,7 +407,7 @@ struct argp_state
>     unknown option is present, ARGP_ERR_UNKNOWN is returned; if some parser
>     routine returned a non-zero value, it is returned; otherwise 0 is
>     returned.  This function may also call exit unless the ARGP_NO_HELP flag
> -   is set.  INPUT is a pointer to a value to be passed in to the parser.  */
> +   is set.  INPUT is a pointer to a value to be passed into the parser.  */
>  extern error_t argp_parse (const struct argp *__restrict __argp,
>                             int /*argc*/, char **__restrict /*argv*/,
>                             unsigned __flags, int *__restrict __arg_index,

Values are being passed in or out from a function. If the direction is the
opposite one, we would write "passed out from the parser", not "passed outfrom
the parser".

Also, https://www.merriam-webster.com/dictionary/pass section "transitive verb"
meaning 7 uses the preposition "to". The value is being passed "to" the parser;
"in" is just the direction.

See also https://idioms.thefreedictionary.com/pass+into .

I think we should revert this one.

Bruno






reply via email to

[Prev in Thread] Current Thread [Next in Thread]