[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Code indentation?
From: |
Simon Josefsson |
Subject: |
Code indentation? |
Date: |
Sun, 10 Sep 2023 08:46:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Bruno Haible <bruno@clisp.org> writes:
> * Commit b93de66735cd6f935ee0970f8cb26908d113e09d introduced mcel.h, but
> it has tabs. Can we untabify
> mcel.h
> mountlist.c
> verify.h
> (as we do with all source files that are not shared with glibc)?
We may have discussed this before, but what do you think about
automating running 'indent' on gnulib source code? Or clang-format,
some projects have switched because it behaves better for them, and GNU
indent releases are far between (which may be a good thing because then
we don't have to re-indent code with every new release).
One way forward could be to:
- Somehow set up a way to identify non-indented code - 'make
indent-check'?
- Run it continously, maybe through some CICD step with output to a web
page.
- Have an exclusion list to opt out of the report.
- Manually go through each identified indentation mis-match and propose
a fix and check if the module maintainer agrees with it, then either
commit the indentation fix or add the file to the exclusion list.
This will take a long time, and I'm not sure it is a good idea, but at
least we would then have a process for code indentation style
conformance in gnulib.
Maybe there are other approaches to this too.
/Simon
signature.asc
Description: PGP signature
- i18n backlog, Bruno Haible, 2023/09/09
- trim.c mbiterf vs mbuiterf, Paul Eggert, 2023/09/09
- untabifying mcel.h, mountlist.c, verify.h, Paul Eggert, 2023/09/09
- documentation for SEE vs MEE etc., Paul Eggert, 2023/09/09
- Re: i18n backlog, Paul Eggert, 2023/09/09
- Code indentation?,
Simon Josefsson <=