bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] printf_parse: fix off-by-two


From: Bruno Haible
Subject: Re: [PATCH] printf_parse: fix off-by-two
Date: Sat, 11 Nov 2023 23:49:26 +0100

Johannes Schindelin wrote:
> In 480a59ba60 (*printf-posix: ISO C 23: Support size specifiers 'wN' and
> 'wfN'., 2023-03-24), a major refactoring hides a bug in the conversion
> of the code handling Windows' `%I64*` family of `printf()` formats:
> before the refactoring, the `64` part was skipped (as desired), but
> afterwards that part is not skipped and therefore the `6` is mistaken
> for a conversion character. Which is invalid, of course, causing the
> code to error out.
> 
> Fix this by skipping the `64` part again.
> 
> This bug was uncovered by the Git for Windows project when `gettext`
> v0.22.3 switched to the gnulib code as work horse of the
> `libintl_vsnprintf()` function.

Thanks. Applied. Will also be cherry-picked to the stable branch.

Bruno






reply via email to

[Prev in Thread] Current Thread [Next in Thread]