Re: test-argp and clang's ASAN

[Simon Josefsson]

Jeffrey Walton <noloader@gmail.com> writes:

>> What should we do?
>>   (A) Ensure that glibc and gnulib argp behave the same:
>>       - Push Sergey's lowercase commit into glibc?
>>       - Revert Sergey's lowercase commit in gnulib?
>> or
>>   (B) Ensure that gnulib overrides glibc:
>>       - Use '#define argp_parse rpl_argp_parse' so that clang doesn't
>>         insert its interceptor?
>
> I don't think capital/lower-case matters. The docs for argp defer to
> GNU Coding Standards [1], and I don't see a treatment in the GNU
> Coding Standards. [2,3]
>
> Maybe a third option is, perform a case insensitive compare. Using
> sentence-case does not materially change the result. I.e., the message
> is conveyed and nothing is broken. So why produce a failure?

I think doing a case-insensitive compare is a good idea short term,
however I would prefer converging glibc and gnulib argp more.

Looking at many traditional GNU tools, it seems --help strings uses
lower-case so can we settle on that?

/Simon

signature.asc
Description: PGP signature