bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 47.


From: Bruno Haible
Subject: Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 47.
Date: Fri, 08 Mar 2024 13:02:48 +0100

Hi Collin,

> Here is a patch that implements the '%reldir%' replacements when
> generating GNU Make output instead of Automake. It seems fairly
> straightforward unless I missed something.

Thanks. I applied both patches.

> Side note, I would like to start making the code _slightly_ more
> readable as more features get implemented. Reducing code duplication
> and such.

That's a good thing to do.

> In this patch I've defined some "constant" (not really because Python)
> regular expressions and and a private helper function.

Quite reasonable.

> I've prefixed
> these with an underscore assuming that no one has a strong dislike for
> this. It is a common convention meaning an interface is only meant for
> internal use [1]. It also allows definitions to not be imported when
> using 'from .GLEmiter import *', for example.

Thanks for mentioning this; I did not know about this property of 'import *'
statements.

Bruno






reply via email to

[Prev in Thread] Current Thread [Next in Thread]