Re: [PATCH] crc: New optimised slice-by-8 implementation

[Sam Russell]

gzip just took my patch to initialise MAINTAINERCLEANFILES, just built from HEAD with gnulib pulled from HEAD, everything looking good

make check

============================================================================
Testsuite summary for gzip 1.13.36-46e9-dirty
============================================================================
# TOTAL: 29
# PASS:  29
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

$ time ./gzip_old -c -d -k large_file.gz > /dev/null

real    0m0.502s
user    0m0.473s
sys     0m0.030s
$ time ./gzip_new -c -d -k large_file.gz > /dev/null

real    0m0.318s
user    0m0.303s
sys     0m0.010s

gzip just needs to update the submodule now? that's another PATCH for them?

On Fri, 1 Nov 2024 at 00:21, Bruno Haible <bruno@clisp.org> wrote:

I wrote:
> And here's the cross-compilation handling that I promised to add.
>
>
> 2024-10-31  Bruno Haible  <bruno@clisp.org>
>
>       crc: Don't attempt to run a compiled C program when cross-compiling.

Here's an improvement:


2024-10-31  Bruno Haible  <bruno@clisp.org>

        crc: Support generating the tables also when cross-compiling.
        * m4/build-cc.m4: New file.
        * modules/crc (Files): Add it.
        (configure.ac): Invoke gl_BUILD_CC. Don't set GL_CROSS_COMPILING.
        (Makefile.am): Use $(BUILD_CC) etc. instead of $(CC) etc.