Re: gnulib-tool.py: Optimize --extract-recursive-dependencies.

[Collin Funk]

Hi Bruno,

Bruno Haible <bruno@clisp.org> writes:

> Could you please fix the ChangeLog entry (s/dependencies/dependents/)?

Oops, good catch. Fixed with the attached.

> And I also see a performance regression in one case:
>
> $ time ./gnulib-tool --extract-dependents stdlib
> $ time ./gnulib-tool --extract-dependents stdlib
> $ time ./gnulib-tool --extract-dependents stdlib
> Before: ca. 0.2 to 0.25 seconds.
> AFter:  1.0 seconds.
>
> In this case, when there is only a single call to getDependents(), it was
> apparently faster to use the 'find modules ...' approach, compared to
> _getAllModules().
>
> Could you please make this case fast again? The way I'm thinking of is to add
> a boolean argument 'top_level_call' to getDependents(), and pass this argument
> as true from main.py and as false from everywhere else.

Thanks, I reproduced your findings. I'll have a look at fixing it with
your suggestions.

Collin

0001-Fix-a-recent-ChangeLog-entry.patch
Description: Text Data