bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] crc: Add PCLMUL implementation


From: Sam Russell
Subject: Re: [PATCH] crc: Add PCLMUL implementation
Date: Tue, 17 Dec 2024 09:06:08 +0100

> Thanks - I have pushed this now.

Thanks :)

> My point was that it would be better to use the same mechanism the .c
> implementation uses in the ./configure check, to make sure it tests for
> what will be used.  That is, drop the CFLAGS changes and add:

I agree from a testability perspective, I've copied the mechanism used in coreutils but since they set CFLAGS for each module then it probably does make more sense to also use the pragma approach inside the autoconf


reply via email to

[Prev in Thread] Current Thread [Next in Thread]