[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-gnupod] New "--podcast-artwork" feature.
From: |
H. Langos |
Subject: |
[Bug-gnupod] New "--podcast-artwork" feature. |
Date: |
Tue, 15 Apr 2008 11:26:21 +0200 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Here's another new feature for podcast support. It allows you to
automatically download the podcast's artwork and add it to the
podcast's files.
Due to limitations in the current implementation you can't add
different pieces of artwork during one run of gnupod_addsong. So you
can't add different artwork for different podcasts in one go yet.
But I guess that most people run gnupod_addsong in a script anyway.
( I would like a hand here from somebody who understands the artwork
related code in gnupod.)
To cleanly apply you'll first need the patch as attached to this
email: fix_a156511d_Change_size_tolerance_for_podcast_cache.patch
The patch for podcast-artwork itself is attached as
feat_1ace2709..54586471_new_podcast-artwork_option.patch
cheers
-henrik
PS: You've got to love "git" it can generate and process patches in
emails (I'm not using this yet) and even export changes you've made
to your local repository, back to the cvs server where you imported from.
PPS: here are the commit messages for the podcast-artwork feature patch
for the curious ones:
...................
commit 54586471b4b2deb9f924ecee5b8b48b33fc666b0
Author: Heinrich Langos <address@hidden>
Date: Tue Apr 15 09:50:47 2008 +0200
Mentioned "--podcast-artwork" feature in help text.
commit a5e5516981b4eaa08e1cbf008c8801d0c3965feb
Author: Heinrich Langos <address@hidden>
Date: Tue Apr 15 03:49:16 2008 +0200
Source code formating change only.
commit 6977c451f8699da5689fbd4bf73aab2a20cea2f2
Author: Heinrich Langos <address@hidden>
Date: Tue Apr 15 03:42:22 2008 +0200
Added "--podcast-artwork" option to download and add artwork to podcasts.
It will try to get the picture referenced by the channel element
"itunes:image" or "image".
I had to make the "DropUnseen" option that removes unused artwork from
the artwork database depend on the non-usage of "--podcast-artwork" because
otherwise every cover but the last would get deleted.
Detail: The information about artwork usage is read during parsing
of GNUtunesDB.xml meaning that at this point the artwork database has
to be loaded. However you can only add artwork BEFORE loading the
database. This works well on the commandline where you already have
the artwork in a file. For podcasts you have to work with data from the
GNUtunesDB.xml before you even download the artwork. Impact on normal
users should me minimal.
commit 37989ae79f8881c1b75ba7f13b6bfeac7249b4be
Author: Heinrich Langos <address@hidden>
Date: Tue Apr 15 01:38:54 2008 +0200
Moved adding of artwork to a sub.
....................
fix_a156511d_Change_size_tolerance_for_podcast_cache.patch
Description: Text Data
feat_1ace2709..54586471_new_podcast-artwork_option.patch
Description: Text Data
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Bug-gnupod] New "--podcast-artwork" feature.,
H. Langos <=