[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain
From: |
Richard van den Berg |
Subject: |
Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain |
Date: |
Thu, 07 May 2009 10:51:04 +0200 |
User-agent: |
Thunderbird 2.0.0.21 (Macintosh/20090302) |
On 5/7/09 10:09 AM, H. Langos wrote:
Did you check when (at which version) MP3::Info gained APE support?
I did just now and APE support was added in MP3::Info v1.20, Saturday,
January 7, 2006
It would
be good to check for this in configure.ac as it already is done for utf8
support.
Configure.ac is now checking for v1.01 from 2002. I guess we can just
change the UTF8 warning into an APE warning and check for v1.20?
Also making sure that older versions don't choke on those extra parameters
would be good. (A short look at the code should be enough.)
I checked and version 1.13 (10 March 2005) should not have any issues
with the additional parameters passed to get_mp3tag().
Are you sure there is always at least one whitespace between the numbers and
the "dB" string? When reading the replaygain related web pages I see that
most people tend to write stuff like "-12dB" or "6dB". I wouldn't be
surprised if some programers followed that example. Or is there some standard
definition for this?
I was actually thinking the same thing. The space is the way mp3gain
does it, but it is not very common to use a space, no. Since mp3gain is
the de facto software to use for calculating ReplayGain it doesn't
really matter though. We can change the \s+ to \s* for completeness
sake. The \s+ was in the code I borrowed, and I just didn't touch it.
BTW: While you're at it ... have you ever seen RVA / RVA2 / XRVA tags
in the wild?
I tag 99% of my own files, but I did see RVA2 tags on some iTunes
mangled files, yes. Note that iTunes uses iTunNORM for Sound Check and
RVA2 for that volume slider thingie. I read a post of someone who volume
leveled his whole collection using that slider.. yikes. I so prefer
mp3gain. :-)
Richard
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain, Richard van den Berg, 2009/05/06
- Message not available
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain,
Richard van den Berg <=
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain, H. Langos, 2009/05/07
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain, H. Langos, 2009/05/07
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain, Richard van den Berg, 2009/05/07
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain, Frank Blendinger, 2009/05/08
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain, Richard van den Berg, 2009/05/08
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain, Frank Blendinger, 2009/05/09
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain, Richard van den Berg, 2009/05/09
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain, H. Langos, 2009/05/09
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain, Richard van den Berg, 2009/05/10
- Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain, H. Langos, 2009/05/10