Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

[Richard van den Berg]

On 5/9/09 9:14 AM, Frank Blendinger wrote:
> > [...]
> > gnupod_convert_OGG.pl uses Ogg::Vorbis::Header which may or may not  
> > support the RG tags. If you send me an ogg file (privately) that  
> > contains RG info I can check (and patch gnupod_convert_OGG.pl).
> >     
>
> I've sent you a private mail on this, it should be easy to do.
>   

Thanks for the file. The attached patch (adding 4 lines of code) takes 
care of it.

Cheers,

Richard

diff -ru gnupod-rg-mp3/src/ext/FileMagic.pm gnupod-cvs/src/ext/FileMagic.pm
--- gnupod-rg-mp3/src/ext/FileMagic.pm  2009-05-09 11:17:53.000000000 +0200
+++ gnupod-cvs/src/ext/FileMagic.pm     2009-05-09 13:01:46.000000000 +0200
@@ -180,6 +180,10 @@
        my $cf = ((split(/\//,$file))[-1]);
        my @songa = pss($metastuff->{_TRACKNUM});
        
+       # Use track ReplayGain by default, use album ReplayGain if requested
+       my $rgtag = "_REPLAYGAIN_TRACK_GAIN";
+       $rgtag = "_REPLAYGAIN_ALBUM_GAIN" if($flags->{'rgalbum'});
+
        $rh{artist}    = getutf8($metastuff->{_ARTIST} || "Unknown Artist");
        $rh{album}     = getutf8($metastuff->{_ALBUM}  || "Unknown Album");
        $rh{title}     = getutf8($metastuff->{_TITLE}  || $cf || "Unknown 
Title");
@@ -188,6 +192,7 @@
        $rh{songnum}   = int($songa[0]);
        $rh{comment}   = getutf8($metastuff->{_COMMENT} || 
$metastuff->{FORMAT}." file");
        $rh{fdesc}     = getutf8($metastuff->{_VENDOR}  || "Converted using 
$encoder");
+       $rh{soundcheck} = _parse_ReplayGain($metastuff->{$rgtag}) || "";
        $rh{mediatype} = int($metastuff->{_MEDIATYPE}   || MEDIATYPE_AUDIO);
        return {ref=>\%rh, encoder=>$encoder, 
codec=>$NN_HEADERS->{$magic}->{ftyp} };
 }
diff -ru gnupod-rg-mp3/src/gnupod_convert_OGG.pl 
gnupod-cvs/src/gnupod_convert_OGG.pl
--- gnupod-rg-mp3/src/gnupod_convert_OGG.pl     2009-05-09 12:42:25.000000000 
+0200
+++ gnupod-cvs/src/gnupod_convert_OGG.pl        2009-05-09 12:40:27.000000000 
+0200
@@ -62,6 +62,8 @@
 print "_TRACKNUM:".( ($ftag->comment('tracknum'))[0] |
                      ($ftag->comment('tracknumber'))[0] )."\n";
 print "_COMMENT:".($ftag->comment('comment'))[0]."\n";
+print 
"_REPLAYGAIN_TRACK_GAIN:".($ftag->comment('REPLAYGAIN_TRACK_GAIN'))[0]."\n";
+print 
"_REPLAYGAIN_ALBUM_GAIN:".($ftag->comment('REPLAYGAIN_ABLUM_GAIN'))[0]."\n";
 print "_MEDIATYPE:".(GNUpod::FileMagic::MEDIATYPE_AUDIO)."\n";
 print "FORMAT:OGG\n";
 }