|
From: | Richard van den Berg |
Subject: | Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain |
Date: | Sun, 10 May 2009 10:35:57 +0200 |
User-agent: | Thunderbird 2.0.0.21 (Macintosh/20090302) |
On 5/10/09 1:35 AM, H. Langos wrote:
I guess we should go this way: 1. Use RVA2/XRVA or (if the former is missing) REPLAY_GAIN_x to compute anew "soundcheck" value. If the first step didn't yield any information: 2. Use iTunNORM's "soundcheck" value and RVA "volume" adjustment.This would probably work for most people.
Agreed. All we really need to make this happen is a parsing of the RVAD tag that iTunes creates for the volume adjustment. For the rest I can write the code myself. ;-)
Do you want to wait until we have a all of the above working before you commit my current ReplayGain patches to CVS?
I just checked and MP3::Info returns each TXXX tag as an individual value (not a hash). So TXXX:replaygain_track_gain="-2 dB" becomes $hs{REPLAYGAIN_TRACK_GAIN}="-2 dB". This means the TXXX tags overwrite the APE ReplayGain tags by default. I just tested this, and it works; when ReplayGain data is set differently in the APE tag and TXXX tag, the TXXX is used by gnupod. Sweet.Great. Did you check if that works with the parameters that FileMagic.pm uses for its get_mp3tag() call?
Yes. I tested this with an actual mp3 and the CVS version of gnupod with my patches applied. It worked without additional modifications.
Cheers, Richard
[Prev in Thread] | Current Thread | [Next in Thread] |