Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

[Jacinta Richardson]

H. Langos wrote:

> One more question:
>
> Why did you use
>  &resetxml; 
> instead of 
>  resetxml();
> ?
>
> I know the former doesn't pass an empty @_ array for the called sub but 
> passes the existing argument list. But you don't do anything with @_ in 
> resetxml(). So why bother passing the current arguments list on to it?

I imagine that the author didn't intend that effect of calling the 
subroutine that way.  I suspect it's a matter of laziness.  FWIW,

        resetxml();

or

        resetxml(@_);   # if necessary

are both many,  many times preferable to:

        &resetxml;

and the latter is generally shunned by experienced, community-minded 
Perl folk.  I'd suggest applying the patch with this tidied up as 
appropriate.

        J