[Bug-gnupod] usage of "$as_echo" vs. "echo" in configure.ac

[H. Langos]

Hi Richard,

I just tried to build gnupod from scratch and it seems that your 
change of replacing "echo" and "echo -n" by "$as_echo" and "$as_echo_n"
breaks the build on debian lenny.

Apparently $as_echo calls are not correctly replaced by autoconf and 
end up in ./configure

Which system did you test it on? And did you remove all the
autoconf/configure temp files for the test?

$ git show-branch --current --sha1-name
[3e23b6f] Merge branch 'releases/0.99.8'
$ git status
# On branch master
nothing to commit (working directory clean)
$ autoconf --version
autoconf (GNU Autoconf) 2.61
$ autoconf
$ ./configure
./configure: line 1622: 0.99.9: command not found
./configure: line 1625:  *** THIS IS A DEVELOPMENT VERSION OF GNUPOD ***: 
command not found
./configure: line 1626:  *** REMEMBER TO ALWAYS BACKUP YOUR DATA :-) ***: 
command not found
./configure: line 1627: -DEVEL: command not found
checking for perl-5.8... no
checking for perl-5.6... no
checking for perl... /usr/bin/perl
checking for pod2man... /usr/bin/pod2man
./configure: line 1722: GNUpod will use /usr/bin/perl: No such file or directory
./configure: line 1730: man page will be generated using /usr/bin/pod2man: No 
such file or directory
./configure: line 1744: checking for Digest::MD5...: command not found
./configure: line 1747:  ok: command not found
./configure: line 1744: checking for Digest::SHA1...: command not found
./configure: line 1747:  ok: command not found
./configure: line 1744: checking for XML::Parser...: command not found
./configure: line 1747:  ok: command not found
./configure: line 1744: checking for Unicode::String...: command not found
./configure: line 1747:  ok: command not found
./configure: line 1744: checking for MP3::Info...: command not found
./configure: line 1747:  ok: command not found
./configure: line 1744: checking for File::Copy...: command not found
./configure: line 1747:  ok: command not found
./configure: line 1744: checking for Date::Parse...: command not found
./configure: line 1747:  ok: command not found
./configure: line 1744: checking for Date::Format...: command not found
./configure: line 1747:  ok: command not found
./configure: line 1744: checking for Data::Dumper...: command not found
./configure: line 1747:  ok: command not found
./configure: line 1761: checking for optional Audio::FLAC::Header...: command 
not found
./configure: line 1764:  ok: command not found
./configure: line 1761: checking for optional Ogg::Vorbis::Header::PurePerl...: 
command not found
./configure: line 1764:  ok: command not found
./configure: line 1761: checking for optional Date::Manip...: command not found
./configure: line 1764:  ok: command not found
./configure: line 1788: installed version of MP3::Info looks good for utf8 
support: command not found
./configure: line 1797: installed version of MP3::Info looks good for APE tag 
and RVA2 support: command not found
./configure: line 1809: checking installed encoders...: command not found
./configure: line 1820:  done: command not found
./configure: line 1823: checking installed decoders...: command not found
./configure: line 1834:  done: command not found
./configure: line 1837: checking for ffmpeg with AAC support... : command not 
found
./configure: line 1840: found!: command not found
./configure: line 1848: checking for ImageMagick...: command not found
./configure: line 1851: found!: command not found
configure: creating ./config.status
config.status: creating Makefile
config.status: WARNING:  Makefile.in seems to ignore the --datarootdir setting
./configure: line 2867: Settings:: command not found
./configure: line 2868: ---------: command not found
./configure: line 2870: Release         : : command not found
./configure: line 2874: Perl Version    : : command not found
5.10.0./configure: line 2879: Prefix          : /usr/local: No such file or 
directory
./configure: line 2881: Perl INC        : : command not found
/etc/perl./configure: line 2886: Encoders        : mpeg4 faac (disabled lame: 
Binary not found) wav: command not found
./configure: line 2887: Decoders        : (disabled timidity: Binary not found) 
flac oggdec : command not found
./configure: line 2888: Artwork Support : Yes: command not found
./configure: line 2892: -> use 'make install' to install GNUpod: command not 
found
./configure: line 2893: -> use 'info GNUpod' to read the documentation after 
you installed GNUpod: command not found
./configure: line 2894: -> use 'make uninstall' to remove GNUpod from 
/usr/local: No such file or directory
$


I checked the configure script and it looks like $as_echo has made it's way
into the configure script and being empty the arguments to echo are interpreted
as commands themselfes. Fortunately we dont have an "$as_echo rm -rf /" in
the configure.ac file :-)

It seems like the problem is not completely new and other
projects have had them too: 
http://www.mail-archive.com/address@hidden/msg17655.html

cheers
-henrik