[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnupod] mktunes: Same settings & version, different databases

From: Nuno J. Silva
Subject: Re: [Bug-gnupod] mktunes: Same settings & version, different databases
Date: Sat, 16 Oct 2010 21:38:17 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

address@hidden (Nuno J. Silva) writes:

> "H. Langos" <address@hidden> writes:
>> If you want to know wether to stay with the sys* functions or to take the
>> non-sys* functions I guess that depends on wether there is anything else 
>> besides sysread and syswrite to that file handle. The perlfunc man page
>> says that "print" is also in the same class of functions as "read" "write"
>> and (<>). Hash58.pm seems pretty straight forward. Go for the sys*
>> functions.
>> But there are other modules that operate on the iTunesDB and iTunesSD. I'd
>> be very greatful if you could check iTunes.pm and Mktunes.pm for mixing of
>> those function groups.
>> a simple "rgrep sysseek *" finds stuff like this:
>> src/tunes2pod.pl:    while(<ITUNES>) {}; sysseek(ITUNES,0,0); # the iPod is 
>> a sloooow mass-storage device, slurp it into the fs-cache
>> which is probably harmless, but revealing.
> I'll see if I find something there.

I've already went through the files, and I hope I missed nothing (I'm
new to perl, but I think I'm understanding the code pretty well).

I didn't see any possible issue in these files, sys* functions are used
and non-sys are used too, but they're used on different file handles:

src/ext/iTunesDB.pm: it does sysseek on $fh, $fd and OTG. Those handles
are always manipulated with sysread and syswrite. PLC is manipulated
through get_int, which is also using sys* functions (including sysseek).

src/ext/Mktunes.pm: opens two files: ITS and ITUNES, both are
manipulated with non-sys functions, and with SeekFix from FooBar.pm
(which also uses non-sys).

I hope this helps :-)

Nuno J. Silva

reply via email to

[Prev in Thread] Current Thread [Next in Thread]