[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnupod] Bug fixes for gnupod.

From: Brad
Subject: Re: [Bug-gnupod] Bug fixes for gnupod.
Date: Tue, 31 May 2011 18:11:10 -0400
User-agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv: Gecko/20110414 Thunderbird/3.1.10

On 31/05/11 2:55 PM, Richard van den Berg wrote:
Hello Brad,

Thanks for the ffmpeg fixes, they look very useful.

On 30-5-11 22:39 , Brad wrote:
  printf "%s" "checking for ImageMagick..."
  convert --version>  /dev/null 2>&1
- if test $? = 0; then
+ if test $? = 1; then

This change is incorrect. Convert returns 0 when it exists. A non-zero
result is expected when it does not exist.

$ convert --version
Version: ImageMagick 6.6.4-0 2010-09-18 Q16 http://www.imagemagick.org
Copyright: Copyright (C) 1999-2010 ImageMagick Studio LLC
Features: OpenMP

$ echo $?
$ notthere --version
-bash: notthere: command not found
$ echo $?

However, the check in configure is informative only. The result is not
used in the perl code of gnupod.

$ convert --version
Version: ImageMagick 6.4.5 2011-05-21 Q16 http://www.imagemagick.org
Copyright: Copyright (C) 1999-2008 ImageMagick Studio LLC

$ echo $?

Anyway, I'll keep that part as a local change for our OpenBSD port just
so developers and so on are not confused about the autoconf script not
finding ImageMagick even though it is there.

This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]