Re: XGDragView bug

[Willem Rein Oudshoorn]

Enrico Sersale <enrico@www.imago.ro> writes:

> The recent changes in XGDragView cause some crashes in GWorkspace.
> 
> This is completly reproducable:
> 
> 1) select a file.
> 
> 2) drag its icon a bit around and then back to its place.
> 
> 3) select an other file to change the contents of the pasteboard.
> 
> 4) try to drag again.
> 
> 5) the app crashes.

Ok, I have found the bug.  It comes down to the fact that the DnD code
in NSWindow is never notified that the drag is finished when the drag 
is unsuccessful. 

The fix of Richard will prevent the crash.  

Unfortunately, it seems that some fundamental change in the DnD code
is necessary.  (Until now the DnD changes were just minor adjustments
of the existing code).   

Adam, I will make want to submit one minor patch (removing the 
Drag Image before depositing the drop) before the next release.

This should fix all the acute problems of GWorkspace.

I suggest that the more fundamental changes are postponed 
until after the gui/xgps release.

Wim Oudshoorn.