Re: [PATCH] tests: fix on systems with broken sh

[Jim Meyering]

Paolo Bonzini wrote:
> This should fix the failure.
>
> * tests/Makefile.am (TESTS_ENVIRONMENT): Adjust coreutils remnants.
> * tests/bre.sh: Invoke script with $SHELL if defined.
> * tests/ere.sh: Likewise.
> * tests/spencer1-locale: Likewise.
> * tests/spencer1.sh: Likewise.
> ---
>  tests/Makefile.am     |    3 +--
>  tests/bre.sh          |    2 +-
>  tests/ere.sh          |    2 +-
>  tests/spencer1-locale |    2 +-
>  tests/spencer1.sh     |    2 +-
>  5 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 242dd6b..17c675d 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -116,8 +116,7 @@ TESTS_ENVIRONMENT =                               \
>    PACKAGE_BUGREPORT='$(PACKAGE_BUGREPORT)'   \
>    PACKAGE_VERSION=$(PACKAGE_VERSION)         \
>    PERL='$(PERL)'                             \
> -  PREFERABLY_POSIX_SHELL='$(PREFERABLY_POSIX_SHELL)' \
> -  REPLACE_GETCWD=$(REPLACE_GETCWD)           \
> +  SHELL='$(SHELL)'                           \
>    PATH='$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \
>    ; shell_or_perl_
>
> diff --git a/tests/bre.sh b/tests/bre.sh
> index 0a1153b..ee5ca93 100755
> --- a/tests/bre.sh
> +++ b/tests/bre.sh
> @@ -14,5 +14,5 @@ failures=0
>
>  ${AWK-awk} -f $srcdir/bre.awk $srcdir/bre.tests > bre.script
>
> -sh bre.script && exit $failures
> +${SHELL-sh} bre.script && exit $failures

This looks right.  I haven't tested on such a system.
Please push it.