[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher
From: |
Paul Eggert |
Subject: |
bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher |
Date: |
Wed, 11 Dec 2019 15:25:48 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 3/22/19 7:49 PM, Norihiro Tanaka wrote:
Missing a patch for dfa. Re-send correct patch file.
Thanks, I installed the DFA-relevant parts of your proposed fix into
Gnulib. (The grep parts still need doing.) I also installed the attached
commentary followup.
While I was at it I installed a patch to fix an unlikely integer
overflow that I noticed while reviewing your fix. I also installed some
internal changes to prefer signed to unsigned integers for indexes, as
this should make future integer overflows easier to catch. See:
https://lists.gnu.org/r/bug-gnulib/2019-12/msg00058.html
https://lists.gnu.org/r/bug-gnulib/2019-12/msg00059.html
I'd also like to change dfa.h's API to prefer ptrdiff_t to size_t, for
the same integer-overflow reason. This would be a (minor) API change so
I thought I'd ask first. Any objections?
PS. Arnold, the above discusses all the changes I know about for dfa.c
and dfa.h. The proposed API change (size_t->ptrdiff_t) could be
installed either before or after the next Gawk release.
0001-dfa-update-commentary-for-previous-change.patch
Description: Text Data
- bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher,
Paul Eggert <=
- bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher, arnold, 2019/12/12
- bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher, arnold, 2019/12/12
- bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher, arnold, 2019/12/12
- bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher, Paul Eggert, 2019/12/12
- bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher, arnold, 2019/12/13
- bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher, arnold, 2019/12/13
- bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher, Jim Meyering, 2019/12/13
- bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher, Paul Eggert, 2019/12/13
- bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher, arnold, 2019/12/15
- bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher, Paul Eggert, 2019/12/16